Issue 5792055: code review 5792055: cmd/dist: move CGO_ENABLED from 'go tool dist env' to '...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5792055: code review 5792055: cmd/dist: move CGO_ENABLED from 'go tool dist env' to '... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by minux1

Modified:
12 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/dist, cmd/go: move CGO_ENABLED from 'go tool dist env' to 'go env' So that we don't duplicate knowledge about which OS/ARCH combination supports cgo. Also updated src/run.bash and src/sudo.bash to use 'go env'.

Patch Set 1 #

Patch Set 2 : diff -r b266610f1677 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b266610f1677 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b266610f1677 https://code.google.com/p/go/ #

Patch Set 5 : diff -r b266610f1677 https://code.google.com/p/go/ #

Patch Set 6 : diff -r b266610f1677 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 4812abcf8f12 https://code.google.com/p/go/ #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -20 lines)			Patch
M	src/cmd/dist/build.c	View	1	2 chunks	+0 lines, -18 lines	0 comments	Download
M	src/cmd/go/env.go	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/run.bash	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/sudo.bash	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 1 month ago (2012-03-09 07:04:00 UTC) #1

minux1

12 years, 1 month ago (2012-03-09 19:42:32 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=885465912b99 ***

cmd/dist, cmd/go: move CGO_ENABLED from 'go tool dist env' to 'go env'
        So that we don't duplicate knowledge about which OS/ARCH combination
        supports cgo.
        Also updated src/run.bash and src/sudo.bash to use 'go env'.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5792055

Expand All Messages | Collapse All Messages