Issue 7011047: code review 7011047: io/ioutil: fix Discard data race

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7011047: code review 7011047: io/ioutil: fix Discard data race (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bradfitz

Modified:
11 years, 3 months ago

Reviewers:

CC:
golang-dev, iant, dvyukov

Visibility:
Public.

Description

io/ioutil: fix Discard data race Fixes issue 4589

Patch Set 1 #

Patch Set 2 : diff -r 2e40253cdd9b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2e40253cdd9b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b07c0f6d6b5f https://go.googlecode.com/hg/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -17 lines)			Patch
M	src/pkg/io/ioutil/blackhole.go	View	1	1 chunk	+14 lines, -4 lines	0 comments	Download
R	src/pkg/io/ioutil/blackhole_race.go	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/pkg/io/ioutil/ioutil.go	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 3 months ago (2012-12-26 21:03:27 UTC) #1

bradfitz

11 years, 3 months ago (2012-12-28 17:33:28 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=4b61f121966b ***

io/ioutil: fix Discard data race

Fixes issue 4589

R=golang-dev, iant, dvyukov
CC=golang-dev
https://codereview.appspot.com/7011047

Expand All Messages | Collapse All Messages