Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: update CLA check mechanism #49696

Closed
dmitshur opened this issue Nov 19, 2021 · 1 comment
Closed

x/build/cmd/gerritbot: update CLA check mechanism #49696

dmitshur opened this issue Nov 19, 2021 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone

Comments

@dmitshur
Copy link
Contributor

gerritbot currently checks whether each PR has a "cla: yes" label (using the maintner corpus, so it doesn't contribute to GitHub API rate limit use) to determine that CLA checks have passed before importing the PR into Gerrit:

ghr.ForeachIssue(func(issue *maintner.GitHubIssue) error {
	// ...
	if /* ... */ || !issue.HasLabel("cla: yes") {
		return nil
	}
	// ...
}

(Source.)

The "cla: yes" and "cla: no" labels have been applied by @googlebot, but are in the process of being deprecated in favor of PR checks (see example). At some point, the "cla: yes" labels will stop being applied, and then gerritbot won't keep importing new PRs automatically, even when the CLAs have been signed.

This issue tracks the work to update gerritbot to use the new mechanism to check that a PR meets the CLA criteria before importing it.

CC @golang/release.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Nov 19, 2021
@dmitshur dmitshur added this to the Unreleased milestone Nov 19, 2021
@dmitshur dmitshur added the Soon This needs to be done soon. (regressions, serious bugs, outages) label Dec 12, 2021
@heschi heschi self-assigned this Dec 13, 2021
@dmitshur dmitshur added this to In Progress in Go Release Team Dec 13, 2021
@gopherbot
Copy link

Change https://golang.org/cl/371815 mentions this issue: cmd/gerritbot: update CLA check

Go Release Team automation moved this from In Progress to Done Dec 15, 2021
@rsc rsc unassigned heschi Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
Archived in project
Development

No branches or pull requests

3 participants