x/exp/winfsnotify: delete package #51447
Comments
|
Change https://go.dev/cl/389615 mentions this issue: |
|
Given the overwhelming evidence, I think we can make this a direct accept. |
|
No change in consensus, so accepted. 🎉 |
rsc
changed the title
|
@bcmills one think we should consider is checking in a go.mod in that directory first, before the delete, so that if anyone really does need it, they can use it as a separate submodule even if they also need a newer x/exp for other reasons. |
|
That seems reasonable. Probably we should also add a deprecation notice to the tombstone version, and tag it something like |
|
Change https://go.dev/cl/399834 mentions this issue: |
For golang/go#51447. Change-Id: I3266073d85e52aa48ba6c8578b2b9b9e26486060 Reviewed-on: https://go-review.googlesource.com/c/exp/+/399834 Reviewed-by: Russ Cox <rsc@golang.org>
|
This is done: the I've also confirmed that the documentation for the final, deprecated version is correctly shown at https://pkg.go.dev/golang.org/x/exp/winfsnotify. |
The
x/exp/winfsnotifypackage was moved from the standard library to thex/exprepository in CL 7456047, a little over nine years ago. It has apparently not been touched since then except to add an// importcomment in 2014. In 2016, users discussed switching to an externally-maintained alternative (see @nathany's comment in #17244 (comment)).At least one such alternative,
github.com/fsnotify/fsnotify, was still actively maintained at least as of this January (see fsnotify/fsnotify#413), and has a number of volunteers to maintain it going forward.In the meantime
x/exp/winfsnotifyhas rotted. It has no active owners and its only substantial test is flaky (#49734). The correspondingfsnotifypackage for Unix platforms was removed in CL 3990, back in 2015.The packages in the
x/exprepository are explicitly experimental. I propose that we declare thex/exp/winfsnotifyexperiment concluded and delete the package.The text was updated successfully, but these errors were encountered: