Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/watch: TestSwitchFromGOPATHToModuleMode failures #57512

Closed
gopherbot opened this issue Dec 29, 2022 · 10 comments
Closed

x/tools/gopls/internal/regtest/watch: TestSwitchFromGOPATHToModuleMode failures #57512

gopherbot opened this issue Dec 29, 2022 · 10 comments
Assignees
@findleyr
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"

Issue created automatically to collect these failures.

Example (log):

#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 18:22:25.309 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-1077134748/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-1077134748/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-1077134748/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 18:22:25.309 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 18:22:25.310 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.82s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.82s)
        watch_test.go:602: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 29, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"
2022-12-29 18:19 freebsd-386-13_0 tools@eac36cb2 go@c1760296 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 18:22:25.309 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-1077134748/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-1077134748/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-1077134748/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 18:22:25.309 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 18:22:25.310 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.82s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.82s)
        watch_test.go:602: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
2022-12-29 18:19 netbsd-amd64-9_3 tools@eac36cb2 go@c1760296 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 18:22:31.619 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-774354831/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-774354831/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-774354831/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 18:22:31.619 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 18:22:31.620 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (1.21s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (1.21s)
        watch_test.go:602: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 29, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 29, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"
2022-12-29 21:26 darwin-amd64-13 tools@1a08d01a go@eeaf508d x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 16:39:30.567 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-regtest-437897821/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-regtest-437897821/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-regtest-437897821/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 16:39:30.567 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.18.9\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 16:39:30.568 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (4.38s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (4.38s)
        watch_test.go:602: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"
2022-12-30 15:52 netbsd-amd64-9_3 tools@b01e7a4e go@c1760296 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 15:55:56.786 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-1081894574/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-1081894574/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-1081894574/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 15:55:56.787 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 15:55:56.787 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.68s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.68s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	main.go (version 2):
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")

            #### outstanding work:
            #### completed work:
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"
2022-12-30 15:52 freebsd-arm64-dmgk tools@b01e7a4e go@db36eca3 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 16:23:20.507 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-4206055855/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-4206055855/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-4206055855/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 16:23:20.508 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel db36eca33c389871b132ffb1a84fd534a349e8d8\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 16:23:20.508 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (1.30s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (1.30s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"
2022-12-30 15:52 darwin-arm64-12 tools@b01e7a4e go@eeaf508d x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 10:57:33.322 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-regtest-771799175/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-regtest-771799175/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-regtest-771799175/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 10:57:33.323 AM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.18.9\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 10:57:33.323 AM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.88s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.88s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
2023-01-02 23:56 darwin-arm64-12 tools@33071fbe go@c1760296 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 18:57:44.354 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-regtest-1749579125/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-regtest-1749579125/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-regtest-1749579125/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 18:57:44.354 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 18:57:44.355 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.44s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.44s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
2023-01-02 23:56 freebsd-amd64-13_0 tools@33071fbe go@db36eca3 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 23:59:05.335 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-1587168827/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-1587168827/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-1587168827/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 23:59:05.336 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel db36eca33c389871b132ffb1a84fd534a349e8d8\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 23:59:05.336 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.83s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.83s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 3, 2023

Based on the timing, I suspect that the flakiness was either introduced or exposed in CL 459785 (attn @findleyr @alandonovan).

@findleyr findleyr self-assigned this Jan 3, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"
2023-01-03 14:55 darwin-amd64-11_0 tools@0441b432 go@eeaf508d x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 10:22:22.750 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-regtest-2006325714/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-regtest-2006325714/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-regtest-2006325714/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 10:22:22.751 AM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.18.9\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 10:22:22.751 AM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (5.59s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (5.58s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	main.go (version 2):
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1

— watchflakes

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.0 Jan 3, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/459560 mentions this issue: gopls/internal/regtest: avoid race in TestSwitchFromGOPATHToModuleMode

@gopherbot gopherbot reopened this Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/watch" && test == "TestSwitchFromGOPATHToModuleMode"
2022-12-29 18:19 freebsd-arm64-dmgk tools@eac36cb2 go@c1760296 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 18:59:57.062 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-1120770441/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-1120770441/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-1120770441/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 18:59:57.063 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 18:59:57.064 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (2.14s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (2.14s)
        watch_test.go:602: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2022-12-30 15:52 linux-amd64-race tools@b01e7a4e go@c1760296 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 16:00:40.423 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-41217934/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-41217934/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-41217934/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 16:00:40.425 PM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 16:00:40.436 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.78s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.78s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            	main.go (version 2):
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2023-01-03 14:55 freebsd-arm64-dmgk tools@0441b432 go@db36eca3 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 15:09:45.979 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-211024667/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-211024667/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir-host-freebsd-arm64-dmgk/tmp/gopls-regtest-211024667/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 15:09:45.980 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel db36eca33c389871b132ffb1a84fd534a349e8d8\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 15:09:45.980 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (2.21s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (2.21s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
2023-01-03 14:55 netbsd-amd64-9_3 tools@0441b432 go@c1760296 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 14:58:14.613 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/workdir/tmp/gopls-regtest-1509078754/TestSwitchFromGOPATHToModuleMode/default/gopath","GOPROXY":"file:///tmp/workdir/tmp/gopls-regtest-1509078754/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/workdir/tmp/gopls-regtest-1509078754/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 14:58:14.614 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.19.4\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 14:58:14.615 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (0.84s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (0.84s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
2023-01-03 14:55 windows-amd64-longtest tools@0441b432 go@db36eca3 x/tools/gopls/internal/regtest/watch.TestSwitchFromGOPATHToModuleMode (log) 
#### Start Gopls Test Logs for "TestSwitchFromGOPATHToModuleMode/default"
[Trace - 15:02:07.720 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"auto","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"C:\\Users\\gopher\\AppData\\Local\\Temp\\1\\gopls-regtest-1592892739\\TestSwitchFromGOPATHToModuleMode\\default\\gopath","GOPROXY":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1592892739/TestSwitchFromGOPATHToModuleMode/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///C:/Users/gopher/AppData/Local/Temp/1/gopls-regtest-1592892739/TestSwitchFromGOPATHToModuleMode/default/gopath/src","name":"src"}]}


[Trace - 15:02:07.720 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.generate_gopls_mod","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel db36eca33c389871b132ffb1a84fd534a349e8d8\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 15:02:07.720 PM] Sending notification 'initialized'.
...
--- FAIL: TestSwitchFromGOPATHToModuleMode (1.50s)
    --- FAIL: TestSwitchFromGOPATHToModuleMode/default (1.50s)
        watch_test.go:603: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing changed files\" at least 1 time(s)\ncompleted work \"diagnosing files changed on disk\" at least 1 time(s)" is met, must have:
            empty diagnostics for "main.go"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
            		(2, 7) [compiler]: could not import mod.com/foo/blah (no required module provides package "mod.com/foo/blah")
            	foo/go.mod (version 0):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	diagnosing files changed on disk: 1
            	diagnosing changed files: 1

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Jan 4, 2023

All those flakes precede the fix.

@findleyr findleyr closed this as completed Jan 4, 2023
@golang golang locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.12.0
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr