New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/analysis: include RelatedInformation in JSON output #64548
Comments
There is very scant documentation on RelatedInformation and it isn't currently used by any of the analyzers in golang.org/x/tools, but it corresponds to the concept of the same name in the https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#diagnostic, and gopls connects them. This proposal seems reasonable to me. |
Thank you for your attention and looking forward to it. |
It's too bad we dont use json to write this json, but we should use a consistent casing for the names, whatever it is. The example says posn/message (lowercase) but then Related (uppercase). |
Agreed, will make the case consistent. |
This proposal has been added to the active column of the proposals project |
Based on the discussion above, this proposal seems like a likely accept. Proposal is to add a new field “related” (lower case) in the JSON object describing each error:
|
Change https://go.dev/cl/556820 mentions this issue: |
Nice!Waiting for release |
No change in consensus, so accepted. 🎉 Proposal is to add a new field “related” (lower case) in the JSON object describing each error:
|
Proposal Details
pass.Report like this
-json output like this
The text was updated successfully, but these errors were encountered: