x/tools/go/packages: publish DriverRequest, DriverResponse #64608
Labels
Proposal
Proposal-Accepted
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Proposal Details
According to #34341 (comment), the lack of public documentation on GOPACKAGESDRIVER is merely an oversight, that I plan to fix in https://go.dev/cl/547977. Internal documentation was added in CL https://go.dev/cl/184943, but the Go types that define the JSON protocol are unexported, meaning users must copy them (e.g. here https://github.com/bazelbuild/rules_go/wiki/Editor-and-tool-integration)
I propose to export them by capitalizing their names and tidying their documentation:
Note: the current internal documentation and behavior support both
os.Getenv("GOPACKAGESDRIVER")
andos.LookPath("gopackagesdriver")
as ways of locating the driver. I'm not convinced that the latter mechanism is desirable (though it may be in current use within Google for Blaze; I should check) and I propose that we drop it.The text was updated successfully, but these errors were encountered: