Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(889)

Issue 136710045: code review 136710045: sync/atomic: add Value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by dvyukov
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

sync/atomic: add Value A Value provides an atomic load and store of a consistently typed value. It's intended to be used with copy-on-write idiom (see the example). Performance: BenchmarkValueRead 50000000 21.7 ns/op BenchmarkValueRead-2 200000000 8.63 ns/op BenchmarkValueRead-4 300000000 4.33 ns/op

Patch Set 1 #

Patch Set 2 : diff -r c79b24056eb1c5836ce808748982cdcee9709597 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r c79b24056eb1c5836ce808748982cdcee9709597 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r c79b24056eb1c5836ce808748982cdcee9709597 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -0 lines) Patch
M src/runtime/thunk.s View 1 1 chunk +6 lines, -0 lines 0 comments Download
A src/sync/atomic/norace.go View 1 1 chunk +17 lines, -0 lines 0 comments Download
A src/sync/atomic/race.go View 1 1 chunk +22 lines, -0 lines 0 comments Download
A src/sync/atomic/value.go View 1 1 chunk +91 lines, -0 lines 0 comments Download
A src/sync/atomic/value_test.go View 1 1 chunk +195 lines, -0 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 7 months ago (2014-09-17 02:52:26 UTC) #1
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=b279bb7f7c3b *** sync/atomic: add Value A Value provides an atomic load and ...
9 years, 7 months ago (2014-09-17 02:53:53 UTC) #2
dvyukov
9 years, 7 months ago (2014-09-17 02:53:59 UTC) #3
Message was sent while issue was closed.
This is a resend of already LGTMed https://codereview.appspot.com/120140044/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b