Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(580)

Issue 147850043: code review 147850043: go.sys/unix: add support for *xattr functions on FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by worr
Modified:
9 years, 6 months ago
Reviewers:
iant
CC:
golang-codereviews, iant
Visibility:
Public.

Description

go.sys/unix: add support for *xattr functions on FreeBSD Add wrappers that provide Linux-y behavior around the FreeBSD extattr(2) functions. This allows certain packages, like the fuse package to run under FreeBSD.

Patch Set 1 : diff -r 55770e785164 https://code.google.com/p/go.sys/ #

Total comments: 10

Patch Set 2 : diff -r 55770e785164 https://code.google.com/p/go.sys/ #

Patch Set 3 : diff -r 55770e785164 https://code.google.com/p/go.sys/ #

Total comments: 9

Patch Set 4 : diff -r 55770e785164 https://code.google.com/p/go.sys/ #

Total comments: 8

Patch Set 5 : diff -r 55770e785164 https://code.google.com/p/go.sys/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+941 lines, -0 lines) Patch
M unix/mkerrors.sh View 2 chunks +4 lines, -0 lines 0 comments Download
M unix/syscall_freebsd.go View 2 chunks +244 lines, -0 lines 0 comments Download
M unix/zsyscall_freebsd_386.go View 1 chunk +231 lines, -0 lines 0 comments Download
M unix/zsyscall_freebsd_amd64.go View 1 chunk +231 lines, -0 lines 0 comments Download
M unix/zsyscall_freebsd_arm.go View 1 chunk +231 lines, -0 lines 0 comments Download

Messages

Total messages: 24
worr
9 years, 7 months ago (2014-09-21 04:30:26 UTC) #1
iant
https://codereview.appspot.com/147850043/diff/20001/unix/syscall_freebsd.go File unix/syscall_freebsd.go (right): https://codereview.appspot.com/147850043/diff/20001/unix/syscall_freebsd.go#newcode29 unix/syscall_freebsd.go:29: var namespaces [3]string = [...]string{"empty", "user", "system"} No need ...
9 years, 7 months ago (2014-09-22 15:49:41 UTC) #2
worr
Ok, I'm happy to fix these issues. Some require further clarification. Reply inline. On 2014/09/22 ...
9 years, 7 months ago (2014-09-22 17:22:08 UTC) #3
iant
On 2014/09/22 17:22:08, worr wrote: > > The point of the struct was so that ...
9 years, 7 months ago (2014-09-22 17:48:51 UTC) #4
iant
On 2014/09/22 17:22:08, worr wrote: > > On 2014/09/22 15:49:41, iant wrote: > > https://codereview.appspot.com/147850043/diff/20001/unix/syscall_freebsd.go ...
9 years, 7 months ago (2014-09-22 17:50:55 UTC) #5
worr
On 2014/09/22 17:50:55, iant wrote: > On 2014/09/22 17:22:08, worr wrote: > > > > ...
9 years, 7 months ago (2014-09-22 17:56:17 UTC) #6
worr
Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.sys/
9 years, 7 months ago (2014-09-23 05:16:19 UTC) #7
iant
https://codereview.appspot.com/147850043/diff/60001/unix/syscall_freebsd.go File unix/syscall_freebsd.go (right): https://codereview.appspot.com/147850043/diff/60001/unix/syscall_freebsd.go#newcode30 unix/syscall_freebsd.go:30: EXTATTR_NAMESPACE_USER = iota + 1 These constants should be ...
9 years, 7 months ago (2014-09-23 14:05:00 UTC) #8
worr
https://codereview.appspot.com/147850043/diff/60001/unix/syscall_freebsd.go File unix/syscall_freebsd.go (right): https://codereview.appspot.com/147850043/diff/60001/unix/syscall_freebsd.go#newcode30 unix/syscall_freebsd.go:30: EXTATTR_NAMESPACE_USER = iota + 1 On 2014/09/23 14:05:00, iant ...
9 years, 7 months ago (2014-09-24 17:02:15 UTC) #9
iant
On Wed, Sep 24, 2014 at 10:02 AM, <ay1244@gmail.com> wrote: > > https://codereview.appspot.com/147850043/diff/60001/unix/syscall_freebsd.go > File ...
9 years, 7 months ago (2014-09-24 21:50:31 UTC) #10
worr
Here's the includes_FreeBSD line that I'm using in mkerrors.sh includes_FreeBSD=' #include <sys/param.h> #include <sys/types.h> #include ...
9 years, 7 months ago (2014-09-24 22:03:36 UTC) #11
iant
On Wed, Sep 24, 2014 at 3:03 PM, Will Orr <ay1244@gmail.com> wrote: > > 39: ...
9 years, 7 months ago (2014-09-25 00:00:49 UTC) #12
worr
package unix /* #include <sys/param.h> #include <sys/types.h> #include <sys/event.h> #include <sys/socket.h> #include <sys/sockio.h> #include <sys/sysctl.h> ...
9 years, 7 months ago (2014-09-25 00:10:49 UTC) #13
iant
Thanks. Unfortunately that looks fine to me. Can you confirm that running go tool cgo ...
9 years, 7 months ago (2014-09-25 00:34:24 UTC) #14
worr
Yeah, I definitely still get the same error. This only happened after adding the sys/extattr.h ...
9 years, 7 months ago (2014-09-25 00:43:13 UTC) #15
iant
On Wed, Sep 24, 2014 at 5:42 PM, Will Orr <ay1244@gmail.com> wrote: > Yeah, I ...
9 years, 7 months ago (2014-09-25 01:17:09 UTC) #16
worr
Thanks. Now that I have an idea on how to proceed, I'll include that in ...
9 years, 7 months ago (2014-09-25 01:33:30 UTC) #17
worr
Hello golang-codereviews@googlegroups.com, iant@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
9 years, 7 months ago (2014-09-25 06:55:07 UTC) #18
iant
https://codereview.appspot.com/147850043/diff/80001/unix/syscall_freebsd.go File unix/syscall_freebsd.go (right): https://codereview.appspot.com/147850043/diff/80001/unix/syscall_freebsd.go#newcode156 unix/syscall_freebsd.go:156: ns = -1 No need to set ns to ...
9 years, 7 months ago (2014-09-25 15:14:33 UTC) #19
iant
Should there be changes to mkerrors.sh in this CL?
9 years, 7 months ago (2014-09-25 15:15:14 UTC) #20
worr
9 years, 6 months ago (2014-10-08 02:48:22 UTC) #21
iant
LGTM
9 years, 6 months ago (2014-10-08 14:28:31 UTC) #22
iant
*** Submitted as https://code.google.com/p/go/source/detail?r=bf4a51c2e4e6&repo=sys *** go.sys/unix: add support for *xattr functions on FreeBSD Add wrappers ...
9 years, 6 months ago (2014-10-08 14:29:30 UTC) #23
worr
9 years, 6 months ago (2014-10-09 03:19:19 UTC) #24
On 2014/10/08 14:29:30, iant wrote:
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=bf4a51c2e4e6&repo=sys ***
> 
> go.sys/unix: add support for *xattr functions on FreeBSD
> 
> Add wrappers that provide Linux-y behavior around the FreeBSD extattr(2)
> functions. This allows certain packages, like the fuse package to run
> under FreeBSD.
> 
> LGTM=iant
> R=golang-codereviews, iant
> CC=golang-codereviews
> https://codereview.appspot.com/147850043
> 
> Committer: Ian Lance Taylor <mailto:iant@golang.org>

Thanks for the help and the merge!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b