Issue 148080043: crypto/tls: ensure that we don't resume when tickets ar...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 148080043: crypto/tls: ensure that we don't resume when tickets ar... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by agl1

Modified:
9 years, 7 months ago

Reviewers:
r, adg

CC:
r, adg, rsc

Visibility:
Public.

Description

crypto/tls: ensure that we don't resume when tickets are disabled.

Patch Set 1 #

Patch Set 2 : diff -r 21a183839336b441cacbc7974aeb58efeed53794 https://code.google.com/p/go #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -1 line)			Patch
M	src/crypto/tls/handshake_server.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/crypto/tls/handshake_server_test.go	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
A	src/crypto/tls/testdata/Server-TLSv12-IssueTicketPreDisable	View	1	1 chunk	+87 lines, -0 lines	0 comments	Download
A	src/crypto/tls/testdata/Server-TLSv12-ResumeDisabled	View	1	1 chunk	+87 lines, -0 lines	0 comments	Download
M	src/crypto/tls/ticket.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

9 years, 7 months ago (2014-09-26 01:02:21 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=8f36a32a9d03 ***

crypto/tls: ensure that we don't resume when tickets are disabled.

LGTM=r
R=r, adg, rsc
https://codereview.appspot.com/148080043

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages