Issue 83020043: code review 83020043: os/exec: always try appropriate command extensions duri...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 83020043: code review 83020043: os/exec: always try appropriate command extensions duri... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by brainman

Modified:
10 years, 1 month ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

os/exec: always try appropriate command extensions during Cmd.Start on windows Update issue 7362 Fixes issue 7377 Fixes issue 7570

Patch Set 1 #

Patch Set 2 : diff -r a07ead0b8bcf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a07ead0b8bcf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4f9de7749827 https://go.googlecode.com/hg/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+389 lines, -152 lines)			Patch
M	src/cmd/pack/pack_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/os/exec/exec.go	View	1	3 chunks	+37 lines, -0 lines	0 comments	Download
M	src/pkg/os/exec/exec_test.go	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/pkg/os/exec/lp_windows_test.go	View	1	5 chunks	+333 lines, -151 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 1 month ago (2014-04-01 06:35:39 UTC) #1

brainman

10 years, 1 month ago (2014-04-04 05:26:25 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0bf0c11aea78 ***

os/exec: always try appropriate command extensions during Cmd.Start on windows

Update issue 7362
Fixes issue 7377
Fixes issue 7570

LGTM=rsc
R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/83020043

Expand All Messages | Collapse All Messages